Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/open Guided tour to all admins #20137

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Mcastres
Copy link
Contributor

What does it do?

This PR opens the Guided Tour to all admins.
It also changes some text for the super-admin GT to be more straightforward.

Why is it needed?

It is too bad that the current Guided Tour is only accessible for super-admins (developers). The idea is to also propose it to non-technical people discovering the product to guide them a little bit.

How to test it?

  • Create a Super-Admin user
  • Create a non-super admin user.

In development environment:
You should get 3 steps for both users which are different based on the user type.

In the production environment:
You should get 4 steps for both users. The extra step is the same step for both which is about inviting a user but it only make sense to have it on production.

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) May 2, 2024 10:01am

@joshuaellis
Copy link
Member

You should probably rebase this off develop so you don't have all the rogue commits in case we forget to squash merge 👍🏼

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback & discussion points :)

@joshuaellis
Copy link
Member

Code all looks good! Let's get the CI going green, then I can QA it 💪🏼

…nents/NewUserForm.tsx

Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
@Mcastres Mcastres added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features labels Apr 25, 2024
@Mcastres
Copy link
Contributor Author

Code all looks good! Let's get the CI going green, then I can QA it 💪🏼

Hey @joshuaellis 👋
There are still some TS errors in the Modal.tsx file that I can't figure out how to fix 🤔
I would appreciate some help whenever you have the time 🙏

[ERROR]  admin/src/components/GuidedTour/Modal.tsx:65:44 - TS2345: Argument of type 'string | number' is not assignable to parameter of type 'string'.
  Type 'number' is not assignable to type 'string'.
[ERROR]  admin/src/components/GuidedTour/Modal.tsx:74:27 - TS2339: Property 'trackingEvent' does not exist on type 'never'.
[ERROR]  admin/src/components/GuidedTour/Modal.tsx:120:67 - TS2339: Property 'title' does not exist on type 'never'.
[ERROR]  admin/src/components/GuidedTour/Modal.tsx:121:63 - TS2339: Property 'cta' does not exist on type 'never'.
[ERROR]  admin/src/components/GuidedTour/Modal.tsx:128:87 - TS2339: Property 'content' does not exist on type 'never'.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Size Change: +280 B (0%)

Total Size: 1.31 MB

Filename Size Change
examples/getstarted/build/main.********.js 1.3 MB +278 B (0%)
ℹ️ View Unchanged
Filename Size Change
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB 0 B
examples/getstarted/build/index.html 611 B +2 B (0%)
examples/getstarted/build/runtime~main.********.js 4.22 kB 0 B

compressed-size-action

@Mcastres
Copy link
Contributor Author

Mcastres commented May 3, 2024

@joshuaellis I'm fixing the front tests and since it's been a whiiiiiiiiile I didn't work with tests, you can start to QA I guess 😅

@joshuaellis
Copy link
Member

I made a new editor user and the guided tour didn't show :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants