fix(database): Add groupBy to queries with joins (option 1) #20124
+198
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
added
source: core:database
innerdvations
requested review from
alexandrebodin,
Marc-Roig,
Convly and
Bassel17
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
innerdvations
changed the title
|
I personally like this option more than option 1, it fixes the problem directly on the db query and I don't think it will impact performance |
|
I may need someone (you?) to sit with me and figure out more precise ways to target where we want to do this. Right now it's breaking components. And I feel like if I fix that case, I'll still keep playing whack-a-mole until our tests pass, and still might miss something. |
innerdvations
added
the
flag: don't merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution: #20125
What does it do?
Removes duplicate results from sorts on relation fields by applying a groupBy on all select statements that don't have one
TODO:
Why is it needed?
Fixes #11892
How to test it?
See the original issue.
A test of
sorthas been added to prevent regressions, but this may have unintended side effects that are not caught by existing tests, so a pretty thorough test of the content API, admin API, pretty much anything that makes queries.Related issue(s)/PR(s)
Alternative solution: #20125
Fixes #11892
DX-117