-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replacing axios with native fetch #20062
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mainly focussed on the getFetchClient
work at the moment, I think the API could be smoother, but left points to discuss.
I think it would really help if you wrote more JSdoc comments on these sort of APIs as a form of documentation too! 😄
@joshuaellis |
Size Change: 0 B Total Size: 2.52 MB ℹ️ View Unchanged
|
packages/plugins/documentation/admin/src/pages/tests/App.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got there in the end, great work ⭐
What does it do?
FetchError
class to replace AxiosErrorWhy is it needed?
How to test it?