fix: improve CM modified date comparison #19898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Roig
changed the title
Marc-Roig
added
source: core:content-manager
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! Makes sense to me. I've merged this into #20258 to check the CI on the tests I was having trouble with. I'll approve if everything works |
|
@jhoward1994 tests were not passing here at the time, so mayabe it's still not enough, but let me know if you want to work on it together! |
|
Okay thanks. I'm working on it a bit in #20258. Sorry it breaks our PR organisation a bit but I need to test it with the e2e tests in that branch. I can cherry pick it here so we can trace it all |
Marc-Roig
commented
May 9, 2024
packages/core/content-manager/server/src/services/document-metadata.ts
Outdated
Show resolved
Hide resolved
Marc-Roig
commented
May 9, 2024
jhoward1994
approved these changes
May 9, 2024
echoes-hq
bot
added
the
echoes/type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Remove the clunky date check for Modified status, now , when publishing on the document service, we assign the updated value of the published version to be exactly the same as the publish version.
Before they were not "exactly" the same, (off by milliseconds) and we had to add a threshold for the check
Reopened from #19787