Merge pull request #18102 from strapi/tests/drop16

strapi · Oct 18, 2023 · e3b3a8b · e3b3a8b
2 parents 5326a28 + 196e541
commit e3b3a8b
Show file tree

Hide file tree

Showing 57 changed files with 71 additions and 69 deletions.
diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.md b/.github/ISSUE_TEMPLATE/BUG_REPORT.md
@@ -20,7 +20,7 @@ https://github.com/strapi/strapi/blob/main/CONTRIBUTING.md#reporting-an-issue
 
 ### Required System information
 
-<!-- Please ensure you are using the Node LTS version (v16 or v18 or v20) -->
+<!-- Please ensure you are using the Node LTS version (v18 or v20) -->
 <!-- Strapi v3 is no longer supported, please update to Strapi v4 -->
 <!-- If you are reporting a frontend bug please provide error logs after setting STRAPI_ENFORCE_SOURCEMAPS=true in your .env -->
 <!-- This environment variable makes frontend errors easier to read and trace -->

diff --git a/.github/actions/check-pr-status/README.md b/.github/actions/check-pr-status/README.md
@@ -19,7 +19,7 @@ This action checks a PR labels, milestone and status to validate it is ready for
 
 ### Requirements
 
-- The code is compatible with Node 16, 18, and 20
+- The code is compatible with Node 18, and 20
 
 ### Dependencies
 

diff --git a/.github/actions/check-pr-status/action.yml b/.github/actions/check-pr-status/action.yml
@@ -1,5 +1,5 @@
 name: 'PR Checker'
 description: 'Check PR status for mergeability'
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'dist/index.js'
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -18,7 +18,7 @@ jobs:
         run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
       - run: yarn
       - run: ./scripts/pre-publish.sh --yes
         env:

diff --git a/.github/workflows/publish-prerelease.yml b/.github/workflows/publish-prerelease.yml
@@ -21,7 +21,7 @@ jobs:
         run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
       - run: yarn
       - run: ./scripts/pre-publish.sh --yes
         env:

diff --git a/.github/workflows/remove-dist-tag.yml b/.github/workflows/remove-dist-tag.yml
@@ -21,7 +21,7 @@ jobs:
         run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
       - run: yarn
       - run: ./scripts/remove-dist-tag.sh
         env:

diff --git a/.github/workflows/skipped_tests.yml b/.github/workflows/skipped_tests.yml
@@ -42,7 +42,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - run: echo "Skipped"
 
@@ -62,7 +62,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - run: echo "Skipped"
 
@@ -72,7 +72,7 @@ jobs:
     name: '[CE] API Integration (postgres, node: ${{ matrix.node }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - run: echo "Skipped"
 
@@ -82,7 +82,7 @@ jobs:
     name: '[CE] API Integration (mysql, node: ${{ matrix.node }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - run: echo "Skipped"
 
@@ -92,7 +92,7 @@ jobs:
     name: '[CE] API Integration (mysql:5 , node: ${{ matrix.node }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - run: echo "Skipped"
 

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -85,7 +85,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - uses: actions/checkout@v4
         with:
@@ -129,7 +129,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
@@ -184,7 +184,7 @@ jobs:
     name: '[CE] API Integration (postgres, node: ${{ matrix.node }}, shard: ${{ matrix.shard }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         shard: [1/2, 2/2]
     services:
       postgres:
@@ -224,7 +224,7 @@ jobs:
     name: '[CE] API Integration (mysql:latest, client: ${{ matrix.db_client }}, node: ${{ matrix.node }}, shard: ${{ matrix.shard }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         db_client: ['mysql', 'mysql2']
         shard: [1/2, 2/2]
     services:
@@ -263,7 +263,7 @@ jobs:
     name: '[CE] API Integration (mysql:5, client: ${{ matrix.db_client }} , node: ${{ matrix.node }}, shard: ${{ matrix.shard }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         db_client: ['mysql', 'mysql2']
         shard: [1/2, 2/2]
     services:
@@ -301,7 +301,7 @@ jobs:
     name: '[CE] API Integration (sqlite, client: ${{ matrix.sqlite_pkg }}, node: ${{ matrix.node }}, shard: ${{ matrix.shard }})'
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         sqlite_pkg: ['better-sqlite3', 'sqlite3']
         shard: [1/2, 2/2]
     steps:
@@ -328,7 +328,7 @@ jobs:
       STRAPI_LICENSE: ${{ secrets.strapiLicense }}
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         shard: [1/2, 2/2]
     services:
       postgres:
@@ -371,7 +371,7 @@ jobs:
       STRAPI_LICENSE: ${{ secrets.strapiLicense }}
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         db_client: ['mysql', 'mysql2']
         shard: [1/2, 2/2]
     services:
@@ -413,7 +413,7 @@ jobs:
       STRAPI_LICENSE: ${{ secrets.strapiLicense }}
     strategy:
       matrix:
-        node: [16, 18, 20]
+        node: [18, 20]
         sqlite_pkg: ['better-sqlite3', 'sqlite3']
         shard: [1/2, 2/2]
     steps:

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16
+20
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -46,7 +46,7 @@ The Strapi core team will review your pull request and either merge it, request
 
 ## Contribution Prerequisites
 
-- You have [Node.js](https://nodejs.org/en/) at version >= v16 and <= v20 and [Yarn](https://yarnpkg.com/en/) at v1.2.0+ installed.
+- You have [Node.js](https://nodejs.org/en/) at version >= v18 and <= v20 and [Yarn](https://yarnpkg.com/en/) at v1.2.0+ installed.
 - You are familiar with [Git](https://git-scm.com).
 
 **Before submitting your pull request** make sure the following requirements are fulfilled:

diff --git a/README.md b/README.md
@@ -94,6 +94,7 @@ Strapi only supports maintenance and LTS versions of Node.js. Please refer to th
 
 | Strapi Version  | Recommended | Minimum |
 | --------------- | ----------- | ------- |
+| 4.14.5 and up   | 20.x        | 18.x    |
 | 4.11.0 and up   | 18.x        | 16.x    |
 | 4.3.9 to 4.10.x | 18.x        | 14.x    |
 | 4.0.x to 4.3.8  | 16.x        | 14.x    |

diff --git a/docs/docs/docs/01-core/strapi/commands/plugin/01-build.md b/docs/docs/docs/01-core/strapi/commands/plugin/01-build.md
@@ -86,9 +86,9 @@ The command sequence can be visualised as follows:
 
 There are three different runtimes available for plugins:
 
-- `node` which equates to a `node16` target
+- `node` which equates to a `node18` target
 - `web` which equates to a `esnext` target
-- `*` (universal) which equates to `["last 3 major versions", "Firefox ESR", "last 2 Opera versions", "not dead", "node 16.0.0"]`
+- `*` (universal) which equates to `["last 3 major versions", "Firefox ESR", "last 2 Opera versions", "not dead", "node 18.0.0"]`
 
 The `node` and `web` targets are specifically used for the export maps with they keys `./strapi-server` and `./strapi-admin` respectively.
 Any other export map values will be transpiled to the universal target. The universal target can be overwritten by adding the `browserslist`

diff --git a/e2e/app-template/package.json b/e2e/app-template/package.json
@@ -16,7 +16,7 @@
     "better-sqlite3": "8.6.0"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "license": "MIT"

diff --git a/examples/getstarted/package.json b/examples/getstarted/package.json
@@ -38,7 +38,7 @@
     "styled-components": "5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/examples/kitchensink-ts/package.json b/examples/kitchensink-ts/package.json
@@ -24,7 +24,7 @@
     "styled-components": "5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/examples/kitchensink/package.json b/examples/kitchensink/package.json
@@ -29,7 +29,7 @@
     "styled-components": "5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/package.json b/package.json
@@ -133,7 +133,7 @@
   },
   "packageManager": "yarn@3.6.4",
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/admin-test-utils/package.json b/packages/admin-test-utils/package.json
@@ -82,6 +82,6 @@
     "@testing-library/jest-dom": "^5.16.5"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x"
+    "node": ">=18.0.0 <=20.x.x"
   }
 }
diff --git a/packages/cli/create-strapi-app/package.json b/packages/cli/create-strapi-app/package.json
@@ -54,7 +54,7 @@
     "tsconfig": "4.14.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/cli/create-strapi-starter/package.json b/packages/cli/create-strapi-starter/package.json
@@ -59,7 +59,7 @@
     "tsconfig": "4.14.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/core/admin/package.json b/packages/core/admin/package.json
@@ -148,7 +148,7 @@
     "@strapi/strapi": "^4.3.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "nx": {

diff --git a/packages/core/content-manager/package.json b/packages/core/content-manager/package.json
@@ -31,7 +31,7 @@
     "qs": "6.11.1"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/packages/core/content-type-builder/package.json b/packages/core/content-type-builder/package.json
@@ -63,7 +63,7 @@
     "styled-components": "5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/packages/core/data-transfer/package.json b/packages/core/data-transfer/package.json
@@ -82,7 +82,7 @@
     "@strapi/strapi": "^4.14.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/core/database/package.json b/packages/core/database/package.json
@@ -55,7 +55,7 @@
     "tsconfig": "4.14.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/core/email/package.json b/packages/core/email/package.json
@@ -85,7 +85,7 @@
     "styled-components": "5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/packages/core/helper-plugin/package.json b/packages/core/helper-plugin/package.json
@@ -104,7 +104,7 @@
     "styled-components": "^5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "nx": {

diff --git a/packages/core/permissions/package.json b/packages/core/permissions/package.json
@@ -49,7 +49,7 @@
     "tsconfig": "4.14.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/core/strapi/README.md b/packages/core/strapi/README.md
@@ -94,6 +94,7 @@ Strapi only supports maintenance and LTS versions of Node.js. Please refer to th
 
 | Strapi Version  | Recommended | Minimum |
 | --------------- | ----------- | ------- |
+| 4.14.5 and up   | 20.x        | 18.x    |
 | 4.11.0 and up   | 18.x        | 16.x    |
 | 4.3.9 to 4.10.x | 18.x        | 14.x    |
 | 4.0.x to 4.3.8  | 16.x        | 14.x    |

diff --git a/packages/core/strapi/package.json b/packages/core/strapi/package.json
@@ -173,7 +173,7 @@
     "typescript": "5.2.2"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "nx": {

diff --git a/packages/core/types/package.json b/packages/core/types/package.json
@@ -68,7 +68,7 @@
     "typescript": "5.2.2"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/core/upload/package.json b/packages/core/upload/package.json
@@ -69,7 +69,7 @@
     "styled-components": "5.3.3"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   },
   "strapi": {

diff --git a/packages/core/utils/package.json b/packages/core/utils/package.json
@@ -62,7 +62,7 @@
     "tsconfig": "4.14.4"
   },
   "engines": {
-    "node": ">=16.0.0 <=20.x.x",
+    "node": ">=18.0.0 <=20.x.x",
     "npm": ">=6.0.0"
   }
 }