Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component for numbered lists referring to annotated screenshots #2099

Merged
merged 6 commits into from May 21, 2024

Conversation

MbonuJennifer
Copy link
Collaborator

In this PR:

Created a component for numbered lists referring to annotated screenshots.

@MbonuJennifer MbonuJennifer added source: repo PRs/issues not targeting a specific documentation but rather affecting the whole repo internal PRs created by the Strapi core team labels May 2, 2024
@MbonuJennifer MbonuJennifer added this to the 4.24.1 milestone May 2, 2024
@MbonuJennifer MbonuJennifer self-assigned this May 2, 2024
@MbonuJennifer MbonuJennifer requested a review from pwizla as a code owner May 2, 2024 11:58
@strapi-cla
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:43am

@pwizla
Copy link
Collaborator

pwizla commented May 2, 2024

Thank you, Jennifer.

Could you at least replace one occurence of a number in one page of the User Guide so we can see how it looks in the preview of this PR?

Then, in this PR (or in another PR, up to you) you'll have to replace ALL occurences of numbers everywhere in the docs by the component, with the proper numbers.
For instance, in the "Introduction to Content Manager" :

From the list view, it is possible to:

  • create a new entry (1),

would become:

From the list view, it is possible to:
- create a new entry <ScreenshotNumberReference number="1"/>,

and so on, everywhere where needs be.

@pwizla
Copy link
Collaborator

pwizla commented May 2, 2024

The component is looking great! I think you can proceed to replace all occurences of screenshot numbers in the documentation. Feel free to do this in this PR, or merge the current PR and create a new branch/PR for the updates.

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pwizla pwizla modified the milestones: 4.24.1, 4.25.0 May 2, 2024
@pwizla pwizla changed the base branch from main to next May 21, 2024 09:09
@pwizla pwizla changed the base branch from next to main May 21, 2024 09:09
@pwizla pwizla removed the request for review from derrickmehaffy May 21, 2024 09:09
@pwizla
Copy link
Collaborator

pwizla commented May 21, 2024

Great, thanks, Jennifer! 🚀

@pwizla pwizla merged commit 6ebd24b into main May 21, 2024
2 of 3 checks passed
@pwizla pwizla deleted the repo/image-number-list-component branch May 21, 2024 09:10
@pwizla pwizla changed the title Created component for numbered lists referring to annotated screenshots Create component for numbered lists referring to annotated screenshots May 21, 2024
@pwizla pwizla added the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label May 21, 2024
MbonuJennifer added a commit that referenced this pull request May 22, 2024
@MbonuJennifer MbonuJennifer removed the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs created by the Strapi core team source: repo PRs/issues not targeting a specific documentation but rather affecting the whole repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants