Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favicon configuration bug #1983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix favicon configuration bug #1983

wants to merge 1 commit into from

Conversation

zlaazlaa
Copy link

What does it do?

The configuration in the documentation for changing the favicon is not functioning properly. I have updated a method that works well.

Why is it needed?

Mitigated a bug.

Related issue(s)/PR(s)

Details about the bug can be found at strapi/strapi#19238.

@zlaazlaa zlaazlaa requested a review from pwizla as a code owner January 19, 2024 06:51
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 6:55am

@strapi-cla
Copy link

strapi-cla commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@pwizla pwizla self-assigned this Jan 19, 2024
@pwizla pwizla added flag: merge pending release Pending Strapi Release source: Dev Docs PRs/issues targeting the Developer Docs pr: updated content PRs updating existing documentation content labels Jan 19, 2024
@pwizla
Copy link
Collaborator

pwizla commented Jan 19, 2024

Hi @zlaazlaa and thanks for the update.
It looks good to me. I'll hold off merging this PR until the corresponding strapi/strapi PR is merged.

@pwizla pwizla changed the title Fix Favicon Configuration Bug Fix favicon configuration bug Jan 19, 2024
@zlaazlaa
Copy link
Author

Hi @zlaazlaa and thanks for the update. It looks good to me. I'll hold off merging this PR until the corresponding strapi/strapi PR is merged.

Thanks a lot❤️

@pwizla pwizla added the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label Jan 19, 2024
@pwizla pwizla removed the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label Feb 22, 2024
pwizla added a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: merge pending release Pending Strapi Release pr: updated content PRs updating existing documentation content source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants