Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The content-manager header has a z-index of 10 while the modal has a z-index of 4 #1344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Sep 12, 2023

What does it do?

  • Fixes issue where the Modal and Dialog appear behind the content-manager because they have a lower z-index value.

Why is it needed?

  • Improve UI/UX when the Modal and Dialog is correctly positioned when opened.

How to test it?

  1. Run the app yarn develop
  2. Find combined-w-scroll in Components and click on Add an entry button.
  3. See that the modal is in front of header.

Demo

https://www.loom.com/share/06f94943db7046fb955bbf8530fa6f65

Before

image

After

image


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: AqidaHaidari <42426077+AqidaHaidari@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

⚠️ No Changeset found

Latest commit: d3a15b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ❌ Failed (Inspect) Sep 12, 2023 7:30am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 7:30am

@gitstart gitstart changed the title STRAP-674 - The content-manager header has a z-index of 10 while the modal has a z-index of 4 fix: The content-manager header has a z-index of 10 while the modal has a z-index of 4 Sep 12, 2023
@gitstart gitstart marked this pull request as ready for review September 12, 2023 07:52
@marco-villanueva
Copy link

If only the z-index of the modal is increased, no options, comboboxes, popovers and I don't know if there are any other components.

In my case what I did was to put the header of the content-manger in 5, the modal in 5 and the others that are hardcoded as the dialog in 5.

@marco-villanueva
Copy link

This worked for me:

HeaderLayout = zIndices[1]
ModalLayout = zIndex: 5
Dialog = zIndex: 5
Tooltip = z-index: 6

@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The content-manager header has a z-index of 10 while the modal has a z-index of 4
4 participants