fix(Box): improve border CSS rendering #1334
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gu-stav
force-pushed
the
fix/border-handling
branch
from
4cc0801
to
0a9d006
Compare
|
Size Change: -235 B (0%) Total Size: 547 kB
ℹ️ View Unchanged
|
gu-stav
force-pushed
the
fix/border-handling
branch
2 times, most recently
from
0a5baf7
to
0493d3d
Compare
gu-stav
commented
Sep 6, 2023
Comment on lines
-39
to
-40
| background={background} | ||
| borderColor="neutral200" |
There was a problem hiding this comment.
Every component that inherits from BaseButton does set these properties explicitly.
gu-stav
force-pushed
the
fix/border-handling
branch
from
0493d3d
to
6fc0156
Compare
gu-stav
force-pushed
the
fix/border-handling
branch
from
6fc0156
to
aba5e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Improves rendering of borders. The previous behavior seems very inconsistent to me and is hart to maintain, as several CSS properties interfere with each other.
This is more of a discussion starter, because I am not sure if we want to implement this in v1 since there is a chance this breaks a few components.
Why is it needed?
I think we can assume we can render a
1px solidborder, if:border-widthANDborder-coloris set (border-style: solid)border-coloris set (border-width: 1px, border-style: solid)border-colorANDborder-styleis set (border-width: 1px)Simplified: we can assume a border of
1px solidas soon as at leastborder-coloris set.borderStyleandborderWidthwould overwrite the style / width.