Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webpack.alias.js from Contribution.md #1299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkcy3
Copy link

@mkcy3 mkcy3 commented Aug 20, 2023

What does it do?

Updates the contribution.md file to equal the online contribution docs.

Why is it needed?

If you visit the design-system and use the contributing docs, it will tell you to remove the package in the webpack config, which is no longer necessary.

https://contributor.strapi.io/guides/working-with-the-design-system

You should also remove the webpack alias for `@strapi/design-system` in the Strapi monorepo at `packages/core/admin/webpack.alias.js`

@vercel
Copy link

vercel bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 2:09pm
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 2:09pm

@mkcy3 mkcy3 changed the title remove webpack.alias.js remove webpack.alias.js from Contribution.MD Aug 20, 2023
@mkcy3 mkcy3 changed the title remove webpack.alias.js from Contribution.MD remove webpack.alias.js from Contribution.md Aug 20, 2023
@joshuaellis joshuaellis added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants