feat: SubNavHeader searchPlaceholder prop

[ChristopheCVB]

What does it do?

Add a searchPlaceholder prop to SubNavHeader component

Why is it needed?

resolves #1201

Related issue(s)/PR(s)

#1201

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 0:48am
design-system-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 0:48am

[gu-stav]

Thank you for this contribution! Would you be able to add a test for this case? 🙏🏼

[ChristopheCVB]

Unfortunately, when I run yarn setup on the root project, I get some errors, here's one:

lerna notice cli v7.1.1


    ×  @strapi/ui-primitives:build
       vite v4.4.3 building for production...
src/components/Collection/Collection.tsx(24,10): error TS4060: Return type of exported function has or is using private name 'CollectionProviderProps'.

✓ 0 modules transformed.
✓ built in 1.72s
Entry module "src/index.ts" cannot be external.
error during build:
RollupError: Entry module "src/index.ts" cannot be external.
    at error (file:///C:/Users/chris/Documents/Personal/design-system/node_modules/rollup/dist/es/shared/node-entry.js:2245:30)
    at ModuleLoader.loadEntryModule (file:///C:/Users/chris/Documents/Personal/design-system/node_modules/rollup/dist/es/shared/node-entry.js:24677:20)
    at async Promise.all (index 0)


    ×  @strapi/icons:build

Also, I'm not a React developer, never dealt with tests in that environment :/
Do you have some tips?

---

I've seen #997 to be able to run setup, but every single e2e test fails :/ I'm clueless at this point

[gu-stav]

@ChristopheCVB Sorry to hear. I see you are running windows? Are you using WSL or something else? I think we have some known problems here and if you prefer I can add tests for you, because fixing the setup might take a bit.

[ChristopheCVB]

Yeah, windows, no wsl, using power shell 7.
If you can add them for me, I'll be extremely grateful

[changeset-bot]

⚠️ No Changeset found

Latest commit: c20f933

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR