fix: LinkButton does not open in new tab #1047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: oxenprogrammer <7220167+oxenprogrammer@users.noreply.github.com> Co-authored-by: raph941 <45232708+raph941@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gitstart
commented
May 16, 2023
| @@ -42,11 +42,23 @@ const LinkWrapper = styled(BaseButtonWrapper)` | |||
|
|
|||
| export const LinkButton = React.forwardRef<HTMLAnchorElement, LinkButtonProps>( | |||
There was a problem hiding this comment.
The current implementation of the Flex and Box components is currently limited due to the utilization of the shouldForwardProp function from styled-components. While it functions well for the majority of use cases, it can pose challenges when we utilize the as property to bind a different component for rendering in the DOM, as the necessary props are not forwarded to the component.
To illustrate this behavior, here's a brief demonstration.
nathan-pichon
added
pr: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes strapi/strapi#16378
What does it do?
isExternalset totrue.Why is it needed?
isExternalset totrueonLinkButton.How to test it?
yarn developLinkButtoninV2and click onDefaultbutton.Demo
Screen.Recording.2023-05-16.at.9.25.15.AM.mov