Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: SubNavHeader search's placeholder can't be customized #1201

Open
ChristopheCVB opened this issue Jul 13, 2023 · 0 comments · May be fixed by #1202
Open

[feat]: SubNavHeader search's placeholder can't be customized #1201

ChristopheCVB opened this issue Jul 13, 2023 · 0 comments · May be fixed by #1202
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package
Milestone
v2.0.0

Comments

@ChristopheCVB
Copy link

A clear and concise description of what the feature is

Be able to set the SubNavHeader search field placeholder

design-system/packages/strapi-design-system/src/v2/SubNav/SubNavHeader.tsx

Line 88 in 3ad7300

placeholder="e.g: strapi-plugin-abcd"

Why should this feature be included?

The placeholder is currently statically set to e.g: strapi-plugin-abcd and is not really helpful

Please provide an example for how this would work

Add a searchPlacholder prop to the component and use it
@ChristopheCVB ChristopheCVB added the issue: enhancement Issue suggesting an enhancement to an existing feature label Jul 13, 2023
@ChristopheCVB ChristopheCVB linked a pull request Jul 13, 2023 that will close this issue
Open
@gu-stav gu-stav mentioned this issue Aug 9, 2023
Closed
@hanpaine hanpaine added source: design-system relates to design-system package community labels Apr 18, 2024
@hanpaine hanpaine assigned joshuaellis and unassigned joshuaellis Apr 18, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package
Projects
Developer Experience Squad
Status: To be reviewed (Open)
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

feat: SubNavHeader searchPlaceholder prop ChristopheCVB/design-system
3 participants
@ChristopheCVB @joshuaellis @hanpaine