Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace links don't open in new tab #16378

Open
remidej opened this issue Apr 13, 2023 · 0 comments · May be fixed by strapi/design-system#1047
Open

Marketplace links don't open in new tab #16378

remidej opened this issue Apr 13, 2023 · 0 comments · May be fixed by strapi/design-system#1047
Labels
issue: bug Issue reporting a bug source: marketplace Source is admin in-app marketplace

Comments

@remidej
Copy link
Contributor

remidej commented Apr 13, 2023

Bug report

Required System information

  • Node.js version: 16.17.0
  • NPM version: 8.15.0
  • Strapi version: 4.9.1
  • Database: sqlite
  • Operating system: macos
  • Is your project Javascript or Typescript: JS

Describe the bug

On the marketplace page in the admin, external links are supposed to open in a new tab. But they open in the same tab instead, making me leave my Strapi app.

Steps to reproduce the behavior

  1. Go to /admin/marketplace
  2. Click on "Submit plugin" at the top of the page
  3. See that it makes you leave Strapi as it doesn't open a new page
  4. Go back to /admin/marketplace
  5. Click on "learn more" on any plugin
  6. Again, it makes you leave Strapi as it doesn't open a new page

Expected behavior

Both "submit plugin" and "learn more" should open a new tab. Their <a> tag target should be _blank instead of _self. This is confirmed by the fact that the React code for the link component has the isExternal prop.

Additional context

I believe these links used to open in a new tab before. And the "missing a plugin" link works as expected.

@remidej remidej added source: marketplace Source is admin in-app marketplace issue: bug Issue reporting a bug labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: marketplace Source is admin in-app marketplace
Projects
Status: To be reviewed (Open)
Status: To review
Development

Successfully merging a pull request may close this issue.

1 participant