Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (cronTasks): account for new date filter format , feat(translations): add french #16

Merged
merged 3 commits into from Mar 4, 2022
Merged

fix (cronTasks): account for new date filter format , feat(translations): add french #16

merged 3 commits into from Mar 4, 2022

Conversation

GautierDele
Copy link
Contributor

closes #15

@GautierDele
Copy link
Contributor Author

GautierDele commented Mar 3, 2022 •
edited

@ComfortablyCoding considering strapi's reaction time to major bugs this could be great merging this one as quick as possible :)

@ComfortablyCoding ComfortablyCoding changed the title Fixes strapi bug for now and added french translation fix (cronTasks): account for new date filter format , feat(translations): add french Mar 3, 2022
ComfortablyCoding
ComfortablyCoding suggested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@ComfortablyCoding ComfortablyCoding left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I have left a comment on where I believe we can improve the changes. Other than the requested change all looks good.

P.S. I am not a Strapi Employee 😅

server/config/cron-tasks.js Outdated Show resolved Hide resolved
@GautierDele
Copy link
Contributor Author

Oh ok there is someone called "daedalus" on their team that's why

@GautierDele @ComfortablyCoding
♻️ added suggestions on code
60a3a0a 
Co-authored-by: daedalus <44623501+ComfortablyCoding@users.noreply.github.com>
@ComfortablyCoding ComfortablyCoding merged commit c0cbcf0 into strapi-community:master Mar 4, 2022
@ComfortablyCoding
Copy link
Contributor

Looks good, tyvm. It will be included in the next release.

Oh ok there is someone called "daedalus" on their team that's why

I believe you are still referring to me, their is no daedalus on the Strapi team.

@GautierDele
Copy link
Contributor Author

@ComfortablyCoding could we make a release only for this since it's kinda blocking the usage ?

@ComfortablyCoding
Copy link
Contributor

Yes, I plan to do one today.

@ComfortablyCoding
Copy link
Contributor

Shipped in v1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComfortablyCoding ComfortablyCoding ComfortablyCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing every time
2 participants
@GautierDele @ComfortablyCoding