CMakeLists: use absolute libdir in rpath handling #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit a26083b (Fixing libdirs for CMakeLists) switched from "${CMAKE_INSTALL_PREFIX}/lib" to "${CMAKE_INSTALL_LIBDIR}". It fixed the issue with lib vs lib64. But while the former is absolute, the latter needs not. That causes troubles as rpath can be set to something like "lib64" only. That is bogus. So fix this by using absolute "${CMAKE_INSTALL_FULL_LIBDIR}" from GNUInstallDirs which is already included and handles the paths correctly. Fixes stp#437.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a26083b (Fixing libdirs for CMakeLists) switched from
${CMAKE_INSTALL_PREFIX}/libto${CMAKE_INSTALL_LIBDIR}. It fixed theissue with
libvslib64. But while the former is absolute, the latterneeds not. That causes troubles as rpath can be set to something like
lib64only. That is bogus.So fix this by using absolute
${CMAKE_INSTALL_FULL_LIBDIR}fromGNUInstallDirswhich is already included and handles the paths correctly.Fixes #437.