New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Move chromatic to scripts
directory
#26233
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f1a7509
move chromatic to script directory
ndelangen bbd2908
Merge branch 'next' into norbert/upgrade-chromatic
ndelangen 8cfa773
add package for `code/ui/.storybook/preview.tsx`
ndelangen 3823695
set `--storybook-config-dir` to root
ndelangen 1b73ae2
Update vite plugin
ethriel3695 2174004
remove unused dependency
ndelangen cf5e82b
Update chromatic script because we cd
ethriel3695 25b7a62
Merge branch 'next' into norbert/upgrade-chromatic
ndelangen 0afea01
remove chromatic as dependency in code
ndelangen 5586855
make it argument optional
ndelangen eea1baf
Merge branch 'norbert/upgrade-chromatic' of https://github.com/storyb…
ndelangen 52314a7
Merge branch 'next' into norbert/upgrade-chromatic
ndelangen 3302212
Merge branch 'next' into norbert/upgrade-chromatic
ndelangen c9a7555
Discard changes to code/frameworks/react-webpack5/README.md
ndelangen d95716f
Discard changes to code/frameworks/react-vite/README.md
ndelangen 56ead87
Merge branch 'next' into norbert/upgrade-chromatic
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
export function isChromatic(windowArg?: any) { | ||
const windowToCheck = windowArg || (typeof window !== 'undefined' && window); | ||
return !!( | ||
windowToCheck && | ||
(windowToCheck.navigator.userAgent.match(/Chromatic/) || | ||
windowToCheck.location.href.match(/chromatic=true/)) | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
--stats-json
now in 8.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethriel3695 Can we change this, as @shilman requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndelangen @shilman We are good to replace the flag with --stats-json