Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storybook to version 8 #687

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update Storybook to version 8 #687

wants to merge 3 commits into from

Conversation

ethriel3695
Copy link
Contributor

@ethriel3695 ethriel3695 commented Mar 21, 2024

This is a draft PR to update Storybook from version 6 to 8.

What I've changed

  • Ran npx storybook@latest upgrade
  • Added babel presets
  • Added babel plugins
  • Added a babel-loader to main.ts
  • Ran the migration for csf-2-to-3
  • Changed some Storybook config files to .ts or .jsx or .tsx

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for storybook-frontpage failed. Why did it fail? →

Name Link
🔨 Latest commit 67ec9bb
🔍 Latest deploy log https://app.netlify.com/sites/storybook-frontpage/deploys/66018dba85af5a00095a3df4

@ethriel3695
Copy link
Contributor Author

ethriel3695 commented Mar 25, 2024

@winkerVSbecks @kylegach
A couple of updates.

  • I added the test-runner and found that some stories fail.

Most are due to mdx is not a function errors.

Test Suites: 9 failed, 79 passed, 88 total
Tests:       25 failed, 174 passed, 199 total
 Message:
     mdx is not a function


    --------------------------------------------------

    Browser logs:

    error: The above error occurred in the <MDXContent> component:

The errors all look to be coming from Screens and the Integrations Catalog Screens.

@jonniebigodes
Copy link
Contributor

@ethriel3695 until we can sort the errors out, you can disable them for the time being. The test runner includes the mechanism for that, see here for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants