Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for slots #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add support for slots #263

wants to merge 1 commit into from

Conversation

djam90
Copy link

@djam90 djam90 commented Apr 21, 2023

It is not currently possible to use slots with the StoryblokComponent.

@djam90 djam90 mentioned this pull request Apr 26, 2023
Open
@alvarosabu alvarosabu linked an issue Apr 27, 2023 that may be closed by this pull request
StoryblokComponent not forwarding slots #268
Open
alvarosabu
alvarosabu approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@alvarosabu alvarosabu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, lets confirm with the rest of the team @Dawntraoz @alexjoverm wdyt?

@alvarosabu alvarosabu added the enhancement [Issue][PR] New feature label Apr 27, 2023
Dawntraoz
Dawntraoz requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Dawntraoz Dawntraoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be a nice addition, thanks a lot, @djam90 😍

The only thing I would love to see is a small section with a use case for slots in the README, maybe close to https://github.com/storyblok/storyblok-vue#short-form. Would you add that for us? It will be amazing 🎉

Thanks again for helping us improve the SDK 💜

@djam90
Copy link
Author

djam90 commented May 10, 2023

Thanks @Dawntraoz I have updated the README to show an example of using slots 😄

@djam90
Copy link
Author

djam90 commented May 16, 2023

@Dawntraoz @alexjoverm could you review please 🙏

@Dawntraoz Dawntraoz self-requested a review May 16, 2023 15:44
@konstantin-karlovich-unbiased-co-uk
Copy link

@djam90 @Dawntraoz @alexjoverm Is there any update here?

@Dawntraoz
Copy link
Contributor

Hi @konstantin-karlovich-unbiased-co-uk, now, my dear @alvarosabu is the one who can help you with this, just to let you know!

Since @djam90 didn't answer the last time, Alvaro, can you plan to take care of this functionality in a new PR? So we can still add it? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

@alexjoverm alexjoverm Awaiting requested review from alexjoverm

@Dawntraoz Dawntraoz Awaiting requested review from Dawntraoz

Assignees
No one assigned
Labels
enhancement [Issue][PR] New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StoryblokComponent not forwarding slots
4 participants
@djam90 @konstantin-karlovich-unbiased-co-uk @Dawntraoz @alvarosabu