Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: build against numpy 2.0.0rc1 + runtime compatibility with numpy 2 in tests #114

Closed
wants to merge 2 commits into from

Conversation

neutrinoceros
Copy link
Contributor

NumPy 2 just reached ABI stability with the release of version 2.0.0rc1 a couple days ago, and forward compatibility with it requires building against this newest version instead of oldest ones.

It is recommended by NumPy developers to plan releases of packages with Python extensions a some point between 2.0.0rc1 and 2.0.0 (final).

@djhoese
Copy link
Collaborator

djhoese commented Apr 12, 2024

Duplicate of #113, but I see you also modified the np.Inf which I hadn't noticed. Let me see if I can merge these two PRs together. I was just waiting on a review of #113 from @mraspaud before merging.

@neutrinoceros
Copy link
Contributor Author

Sorry I didn't search enough. Feel free to incorporate the inf change in you PR and close this one if it makes things easier for you guys !

@djhoese djhoese closed this Apr 12, 2024
@neutrinoceros neutrinoceros deleted the numpy2_compat branch April 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants