Adding scroll to form if ID is requested in hash #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbp
reviewed
Dec 14, 2021
mjbp
reviewed
Dec 14, 2021
mjbp
requested changes
Dec 14, 2021
mjbp
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to form render function so that if the window URL has a hash that matches the ID of the newly rendered form, then the window will scroll to it.
This is to resolve the bug where the form isn't always rendered quickly enough for the browser to recognise the jump-to default behaviour from the hash.
I'm not sure that my attempt to test this will actually do anything here in the JEST DOM?