Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Fix dynamic call screwing up values #511

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mitrokosta
Copy link
Member

@mitrokosta mitrokosta commented Nov 21, 2023

ExpressionResult may contain a reference to an object after returning from BC_CallFunction. Script example that insta crashes the game before this fix (most of the time, sometimes it hides MC's portrait):

void Suicide()
{
	ref sld = CharacterFromID("Blaze");
}

void ActiveF10Control()
{
	string death = "Suicide";
	call death();
}

Suicide() caused ExpressionResult to have a reference to an object (reference to main character). ExpressionResult.Set(0); sets the object's type to int which is obviously bad.

@q4a
Copy link
Contributor

q4a commented Nov 22, 2023

Linux fail because of Clang 12 removed from Ubuntu 22.04 CI image: actions/runner-images#8263
I'll try to fix CI today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants