Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug UI tests in Jenkinsfile.public (do not merge) #6841

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mobyvb
Copy link
Member

@mobyvb mobyvb commented Mar 8, 2024

Change-Id: I2bde1f159792803c4e32dff2bad6dcce03e98068

What:

Why:

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

Change-Id: I2bde1f159792803c4e32dff2bad6dcce03e98068
Change-Id: I7af45c70bcade353c9b3f074976ce95ada203e43
Change-Id: Ibb74b277ed62f536b187eaafc86564be4cb5bba7
Change-Id: I712c747b3b9953dcb7f597c47cd3e6005238981f
Change-Id: I2cbe53a250d743dd202205745f7bd32f9fc10720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant