Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/testplan: add admin UI testplan #6592

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs/testplan: add admin UI testplan #6592

wants to merge 4 commits into from

Conversation

littleskunk
Copy link
Member

What: A testplan for the new admin UI aka backoffice.

Why: We had some issues with the old admin UI. It overrides the placement constraint in some situations. Luckily we noticed it and corrected the placement constraint. To make sure this doesn't happen again we should spend a bit more time on tests.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

ihaid
ihaid previously approved these changes Dec 8, 2023
ifraixedes
ifraixedes previously approved these changes Dec 28, 2023
Copy link
Member

@ifraixedes ifraixedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I dropped a couple of comments for a functionality that was not planed for v1.

I would suggest @stoweandi to review it too.

@littleskunk if you think that we should have a meeting, let's schedule one.

docs/testplan/admin-ui.md Outdated Show resolved Hide resolved
docs/testplan/admin-ui.md Outdated Show resolved Hide resolved
@ifraixedes ifraixedes self-requested a review December 28, 2023 11:27
@littleskunk littleskunk dismissed stale reviews from ifraixedes and ihaid via 713b037 January 12, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants