Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright UI #6014

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Playwright UI #6014

wants to merge 55 commits into from

Conversation

neo-cypher
Copy link
Contributor

What: Playwright Automated UI Tests

Why: Because we need automated UI test coverage in order to limit the gaps in our current manual testing.

Please describe the tests:

  • Test 1: Bunches of tests which can't be documented here in a meaningful way.

Please describe the performance impact:

  • This change is ran in its own jenkins job and as of now has very little or possibly non performance impact. However these tests can grow over time and may eventually become a bottleneck for PRs that have passed all other checks and awaiting a pass from the ui test job.

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

This commit removes the outdated playwright tests so that they can be replaced
with the most up to date version.
This commit implements the most up to date version of the ui tests.
This commit pushes the jenkinsfile that is required for a ui test to be
performed in the pipeline. Any branch with an assoicated github pr that
contains this file will automatically execute the jenkins job.

Further hooks will be implemented in a future PR to allow UI tests on
gerrit changes.
@neo-cypher neo-cypher added WIP Work In Progress ui-tests labels Jul 5, 2023
@neo-cypher neo-cypher self-assigned this Jul 5, 2023
@cla-bot cla-bot bot added the cla-signed label Jul 5, 2023
@neo-cypher neo-cypher marked this pull request as draft July 5, 2023 12:27
neo-cypher and others added 22 commits July 5, 2023 09:20
UI tests are now configured to connect to the local services instead of
using the nightly build.
Gateway was calling gateway-mt executable
Removed linting, auditing, and testing of web ui code. This copy over was redundant to the .verify jenkins job and should reduce overall test runtime.
Gateway was calling gateway-mt executable
Removed linting, auditing, and testing of web ui code. This copy over was redundant to the .verify jenkins job and should reduce overall test runtime.
Fixes typo in Jenkinsfile.ui
Tests dont set the port assignment when pulling configuration parameters from testConfig.ts. Instead of fixing all the tests I just added the port to the baseurl.
added allure reporting dependency to the node modules dependencies.
neo-cypher and others added 24 commits August 8, 2023 06:08
disables the limiter on the console auth endpoint
updated .gitignore to exclude html-report directory from commits
diff --git a/Jenkinsfile.ui b/Jenkinsfile.ui
index b8f212a9e..973ba0c50 100644
--- a/Jenkinsfile.ui
+++ b/Jenkinsfile.ui
@@ -16,6 +16,7 @@ pipeline {
         GOTRACEBACK = 'all'
         COCKROACH_MEMPROF_INTERVAL=0
         PLAYWRIGHT_BROWSERS_PATH= '/ms-playwright'
+        SLACK_WEBHOOK_URL = credentials('SLACK_WEBHOOK_URL')
         SLACK_BOT_USER_OAUTH_TOKEN = credentials('SLACK_BOT_USER_OAUTH_TOKEN')

     }
diff --git a/Jenkinsfile.ui b/Jenkinsfile.ui
index b8f212a9e..973ba0c50 100644
--- a/Jenkinsfile.ui
+++ b/Jenkinsfile.ui
@@ -16,6 +16,7 @@ pipeline {
         GOTRACEBACK = 'all'
         COCKROACH_MEMPROF_INTERVAL=0
         PLAYWRIGHT_BROWSERS_PATH= '/ms-playwright'
+        SLACK_WEBHOOK_URL = credentials('SLACK_WEBHOOK_URL')
         SLACK_BOT_USER_OAUTH_TOKEN = credentials('SLACK_BOT_USER_OAUTH_TOKEN')

     }
Modify the jenkinsfile to call the regular test instead of the test-debug.
this build is for debugging purposes only.
This commit adds the login test and updates the test-debug script in the package.json file.
gitignore updated to allow commiting of test.ts file.
updated package.json to use playwright 1.37.1.
Force the browser to use chromium instead of chrome. Chrome requires some packages that arent on the ci-image but generally its not needed to run the full desktop verseion.
this commit forces chromium instead of chrome.
this commit forces chromium instead of chrome.
storjBuildBot pushed a commit that referenced this pull request Dec 15, 2023
This change copies over the updated playwright tests from the draft
PR #6014

Issue: #6597

Change-Id: Ief1523c4289bbbcfaada0e3632ffa7e0fff457ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants