Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test-sim-rolling-upgrade.sh #5658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix test-sim-rolling-upgrade.sh #5658

wants to merge 1 commit into from
+56 −0

Conversation

thepaul
Copy link
Contributor

@thepaul thepaul commented Mar 9, 2023

This test involves a satellite with dev defaults (DistinctIP=no) being upgraded past commit 2522ff0, which means we need to run the dev-defaults-satellite-upgrade migration SQL to avoid getting DistinctIP=yes behavior:

UPDATE nodes SET last_net = last_ip_port

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@cla-bot cla-bot bot added the cla-signed label Mar 9, 2023
@thepaul
scripts/tests: fix test-sim-rolling-upgrade.sh
6d01cd9 
This test involves a satellite with dev defaults (DistinctIP=no) being
upgraded past commit 2522ff0, which
means we need to run the dev-defaults-satellite-upgrade migration SQL
to avoid getting DistinctIP=yes behavior (which breaks the tests).

Change-Id: I29fb596d1ffa568dad635d98cfe9abacd3aaa48f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thepaul