Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storagenode/reputation: unit test coverage #5515

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

neo-cypher
Copy link
Contributor

This change implements unit tests for service.go in the reputation package. This change increases test coverage by 3.6%.

What:

Why:

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

This change implements unit tests for service.go in the reputation package. This change increases test coverage by 3.6%.
@neo-cypher neo-cypher added the WIP Work In Progress label Jan 25, 2023
@neo-cypher neo-cypher self-assigned this Jan 25, 2023
@cla-bot cla-bot bot added the cla-signed label Jan 25, 2023
This change implements unit tests for service.go in the reputation package. This change increases test coverage by 3.6%.
This commit implements unit tests in the satellite relative to auditing and (re)verification. Also pushes some test coverage in the storage node via nodestat services.
@neo-cypher neo-cypher removed the WIP Work In Progress label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants