chore: refactor advertising.js to improve readability #104
+110
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSnow
requested changes
May 21, 2023
HelloAlexPan
changed the title
|
Awesome work @PoChenKuo — fix DS issues 
|
|
@DanSnow |
HelloAlexPan
changed the title
HelloAlexPan
changed the title
Thanks for opening this PR @PoChenKuo; this is really great work. As this is a minor refactor, reviewing this PR is a lower priority, and the team will try to review this and get it merged in the coming weeks. Feel free to let me know what other improvements you like to be made to this library, either here or as an issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of advertising.js to make it more readable.
@DanSnow
Please help to review it.