Feature/react window #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbemac
previously requested changes
Jan 1, 2019
Should we be memoizing the row before passing it into react-window? They have an example of doing this in their docs using their
Seems to work:
|
|
Yeah, I use that memoization technique in Tree-List already. |
Should we add it to the storybook too? Or should our ScrollList just do this for you by default? |
|
Sure, will include it. |
|
Removed my review - leaving @lottamus to give final review. |
lottamus
approved these changes
Jan 7, 2019
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news is Firefox supports CSS Scrollbars as of 64 version so we should have fairly consistent scrollbar styling for everywhere using plain CSS. The only subtle difference is lack of border-radius.