bugfix #135 handle draining messages after unsubscribe #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clients use `auto ack` and `unsubscribe` it's possible that messages are considered as processed, while they have never been forwarded by `read`. In order to avoid accidental message los a DrainingConsumer state was added, that comes together with the `DrainingMessageException`. Access to `Parser` internal buffer has been simplified, by adding `isBufferEmpty`. Same applies for `Client` here `isBufferEmpty` and `flushBufferedFrames` were added.
staabm
reviewed
Jun 15, 2020
| use Stomp\Transport\Frame; | ||
| use Stomp\Transport\Message; | ||
|
|
||
| class DrainingConsumerState extends StateTemplate |
There was a problem hiding this comment.
Would be great to have a class-doc what this state represents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clients use
auto ackandunsubscribeit's possible that messages are considered as processed, while they have never been forwarded byread.In order to avoid accidental message los a DrainingConsumer state was added, that comes together with the
DrainingMessageException.Access to
Parserinternal buffer has been simplified, by addingisBufferEmpty.Same applies for
ClienthereisBufferEmptyandflushBufferedFrameswere added.