Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add I2C slave. #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

matoushybl
Copy link
Contributor

This adds an I2C slave implementation for I2C1 that I developed for use in a personal project. This is a very much WIP as no support for I2C2 is available and the code is not compliant with anything in embedded-hal.

It'd be nice if this could be discussed here what can be done to make this code mergeable as there are almost none examples of implementing I2C slave for STM32 and other controllers.

@matoushybl matoushybl reopened this Dec 24, 2020
@matoushybl matoushybl changed the title [WIP] Add I2C slave. Add I2C slave. Dec 24, 2020
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋.

Thanks for this PR. I think with 3 more changes we can merge this:

  • Address the commented out code, including potentially adding some more commentary
  • Add a CHANGELOG entry
  • Add example code so people can directly try the slave functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants