Add dual bank related fields to stm32g4 cat 3 devices #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Correct me if I am wrong, but from what I can tell FLASH_OPTR gets its value from here automatically at boot. Because of that, FLASH_OPTR does not have a reset value per say. However the place that it gets its value from does, 0xFFEFF8AA. Would it then make sense to define FLASH_OPTR's resetValue as 0xFFEFF8AA?(see c7fe7d7) |
|
@adamgreig or anyone else, might I request a review and a new CI run (I do not think/hope the error is because of me) :) Also, what/are there any plans for a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing dual bank flash related fields to stm32g4 devices: