Added cookbooks to backup/restore #2
Conversation
| else | ||
| raise | ||
| end | ||
| end |
There was a problem hiding this comment.
Could you split this off into a different commit?
There was a problem hiding this comment.
Okay. This snuck in there. This was done because I had restores fail for various reasons and then it would bomb here.
|
Thanks for taking the time to submit this pull request. I will need to look into whether you will need a CLA for this code. If you aren't opposed to signing one, it will also make contributing to Chef and other knife plugins easier. The directions for filling it out are here: |
| @@ -38,6 +38,7 @@ def run | |||
| roles | |||
| data_bags | |||
| environments | |||
| cookbooks | |||
There was a problem hiding this comment.
It might make sense to add an option for whether or not to upload cookbooks. Hopefully you would restore cookbooks from your local source code repository rather than a backup.
There was a problem hiding this comment.
This was a quick and convenient way to grab all versions of a cookbook that had been uploaded. A flag probably makes sense.
|
In this "official" Opscode code? |
|
Most everything in this repository is very UNOFFICIAL. However, since I am not the original author of some of the backup_export code, I just want to be sure about what is needed in this case. |
Hacky I know.