Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dos2unix converter script #383

Closed
wants to merge 2 commits into from
Closed

Conversation

tanj
Copy link

@tanj tanj commented Apr 19, 2024

Add dos2unix formatter.

This is convenient simple formatter that fixes when a formatter (such as isort on windows) changes the line endings of streamed text.

@stevearc
Copy link
Owner

stevearc commented May 6, 2024

Can you take a look at #395 as an alternative solution? I believe this approach is cleaner than adding a new formatter.

@tanj
Copy link
Author

tanj commented May 10, 2024

yes, your solution in #395 resolves my issue and I agree that is a better solution

@tanj tanj closed this May 10, 2024
@tanj tanj deleted the dos2unix branch May 10, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants