Prefer DynamicMemberLookup over KVC #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏻 Hello @djbe , I am finishing Linux support for Sourcery. At the moment this line of code is a blocker, would it be possible to merge this MR anytime soon? I can see that this repo is unmaintained. I have resources to setup CI here and maybe I'll need to merge some more MRs before Sourcery Linux port would be finished. I'd love to be collaborator here and support the project 🙏🏻 |
djbe
requested changes
Aug 26, 2023
There was a problem hiding this comment.
Unfortunately the danger step doesn't work from other repos… Anyway, you're missing a changelog entry.
📝 We use the following format for CHANGELOG entries:
* Prefer `DynamicMemberLookup` over KVC.
[##342](https://github.com/stencilproject/Stencil/pull/342)
[@art-divin](https://github.com/art-divin)
💡 Don't forget to end the line describing your changes by a period and two spaces.
djbe
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On non-Darwin platforms KVC is not supported, thus check in
Variable.swift:115is returningnil.While this technically cannot be solved, it would be better to first attempt to get value via
DynamicMemberLookupprotocol conformance.This change is required for Sourcery linux support: krzysztofzablocki/Sourcery#1188