Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: stencila authorship component 2206 #2214

Merged
merged 11 commits into from May 12, 2024

Conversation

mike-parkin
Copy link
Collaborator

@mike-parkin mike-parkin commented May 8, 2024

details

web-compoent for <stencila-authorship> created

  • adds the background shading based on the 'mi' property.
  • tooltip on hover, shows author count and provenance.
  • only shows the provenance when the relevant Entity's node card is open

image
image

Due to complexity issues, the current toggling of the provenance can only be attached to a single Entity,
for example: a Paragraph entity will only display its provenance shading when the Paragraph node card is open, not when the Instruction block is open at this point

This is due to the CustomEvents that control the context values bubbling up and triggering multiple listeners.
Expanding

related issues: #2206 items B & D

@mike-parkin mike-parkin marked this pull request as draft May 8, 2024 04:59
5: '#77a0f5', // blue-400
}

export type ProvenanceHighlightLvl = keyof typeof provenanceHighlights
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You and your cutbacks! To save an old fart like me a few brain cycles could your neo-liberal fingers spare a couple more characters?

Suggested change
export type ProvenanceHighlightLvl = keyof typeof provenanceHighlights
export type ProvenanceHighlightLevel = keyof typeof provenanceHighlights

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surporised you didn't comment on this one:

export const getProvHighlight = (miLvl: ProvenanceHighlightLvl) =>

Copy link
Member

@nokome nokome May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nauseating.

@mike-parkin mike-parkin marked this pull request as ready for review May 9, 2024 22:08
@mike-parkin mike-parkin changed the title Draft: Feature/stencila authorship component 2206 Feature: stencila authorship component 2206 May 9, 2024
@nokome nokome merged commit c9fbcb1 into main May 12, 2024
7 of 8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/stencila-authorship-component-2206 branch May 12, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants