New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: stencila authorship component 2206 #2214
Conversation
5: '#77a0f5', // blue-400 | ||
} | ||
|
||
export type ProvenanceHighlightLvl = keyof typeof provenanceHighlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You and your cutbacks! To save an old fart like me a few brain cycles could your neo-liberal fingers spare a couple more characters?
export type ProvenanceHighlightLvl = keyof typeof provenanceHighlights | |
export type ProvenanceHighlightLevel = keyof typeof provenanceHighlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surporised you didn't comment on this one:
export const getProvHighlight = (miLvl: ProvenanceHighlightLvl) =>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nauseating.
details
web-compoent for
<stencila-authorship>
createdEntity
's node card is openDue to complexity issues, the current toggling of the provenance can only be attached to a single
Entity
,for example: a Paragraph entity will only display its provenance shading when the Paragraph node card is open, not when the Instruction block is open at this point
This is due to the
CustomEvents
that control the context values bubbling up and triggering multiple listeners.Expanding
related issues: #2206 items B & D