[ANCHOR-686] Add user_action_required_by
#1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
changed the title
user_action_required_by
Code Coverage
|
JiahuiWho
approved these changes
May 17, 2024
JiahuiWho
reviewed
May 17, 2024
core/src/test/kotlin/org/stellar/anchor/sep24/Sep24ServiceTest.kt
Outdated
Show resolved
Hide resolved
JiahuiWho
reviewed
May 17, 2024
core/src/test/kotlin/org/stellar/anchor/sep24/Sep24ServiceTest.kt
Outdated
Show resolved
Hide resolved
philipliu
reviewed
May 17, 2024
| every { sep24Config.initialUserDeadlineSeconds } returns deadline | ||
| sep24Service.withdraw(createTestSep10JwtWithMemo(), createTestTransactionRequest()) | ||
| val dbDeadline = slotTxn.captured.userActionRequiredBy.epochSecond | ||
| val expectedDeadline = Instant.now().plusSeconds(deadline).epochSecond |
There was a problem hiding this comment.
We really should be injecting a Clock everywhere 😢
There was a problem hiding this comment.
Created a task for that
https://stellarorg.atlassian.net/browse/ANCHOR-705
platform/src/main/java/org/stellar/anchor/platform/rpc/RpcMethodHandler.java
Show resolved
Hide resolved
philipliu
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
user_action_required_byto SEP-6/24/31 transactions and related DB entries.user_action_required_byfieldContext
Implements stellar/stellar-protocol#1484
Testing
./gradlew testDocumentation
https://stellarorg.atlassian.net/browse/ANCHOR-688
https://stellarorg.atlassian.net/browse/ANCHOR-704
Known limitations
N/A