[ANCHOR-687] Upgrade to JDK-17 #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijamie98
changed the title
lijamie98
changed the title
Ifropc
approved these changes
May 17, 2024
| @@ -1,4 +1,4 @@ | |||
| ARG BASE_IMAGE=gradle:7.6.4-jdk11-alpine | |||
| ARG BASE_IMAGE=gradle:7.6.4-jdk17-alpine | |||
There was a problem hiding this comment.
We should upgrade gradle to latest in 3.0 if we haven't already
There was a problem hiding this comment.
This makes least impact to 2.x. We can do major upgrades in v3.
| if (detail instanceof Exception) { | ||
| Exception ex = (Exception) detail; | ||
|
|
||
| logMessageWithJson( |
There was a problem hiding this comment.
Why is this required now? Does the message get collapsed?
There was a problem hiding this comment.
This is because logMessageWithJson(message, detail, getLogger()::error); failed serializing the message field if detail is an exception.
That's the reason that we have expand it manually.
…grade-to-jdk17-27
lijamie98
changed the title
philipliu
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Testing
./gradlew testDocumentation
Update
How to Contributedoc.Known limitations
N/A