Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20190819 doc updates #3469

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

20190819 doc updates #3469

wants to merge 10 commits into from

Conversation

Gandalf-the-Grey
Copy link
Contributor

Fixes #3451

  • some other minor changes.

@Gandalf-the-Grey
Update README.md
1fdb097 
small fixes, no point for specifying full node requirements, as there's no longer monolithic config being used in the wild
follows / tags are handled by hivemind, thus, low_memory_node=off is more like "fat" node than full
variety of different possible configuration (mira/non-mira, plugins, settings) can largely affect disk/memory requirements
@Gandalf-the-Grey
Update Dockerfile
04ea311 
no more git submodules, duplicate gdb
@Gandalf-the-Grey
Update config-for-docker.ini
6457a29 
no market plugin here, so having related settings uncommented is just confusing
follow plugin is obsolete
seed-node is obsolete
@Gandalf-the-Grey
Update config-for-ahnode.ini
db2a8ac 
removed confusing unrelated or obsolete settings
@Gandalf-the-Grey
Update config-for-broadcaster.ini
2bc0c2f
@Gandalf-the-Grey
Update fullnode.config.ini
092ca5e
@Gandalf-the-Grey
NVMe
75e72f5
@Gandalf-the-Grey
Update example_config.ini
af99d4a 
follow obsolete
market-history not here
seed-node obsolete
@Gandalf-the-Grey
obsolete, redundant
c7ae6a1 
replaced by exchangequickstart.md and README.md
@Gandalf-the-Grey
Update building.md
a4e63c5 
Ubuntu 14.04 LTS reached EOL (with normal support)
Instructions for Ubuntu 16.04 LTS seems to be pretty much same as for Ubuntu 18.04 LTS
Added info about MIRA cmake switch.
Added info about open file limits.
Gandalf-the-Grey
Gandalf-the-Grey commented Aug 19, 2019
View reviewed changes
Dockerfile
@@ -41,7 +41,6 @@ RUN \
jq \
wget \
virtualenv \
gdb \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

444

@Jolly-Pirate
Copy link
Contributor

They kept seed-node = in the config.ini for backward compatibility.

@Gandalf-the-Grey
Copy link
Contributor Author

They kept seed-node = in the config.ini for backward compatibility.

No. Most likely you are mixing that with doc/seednodes.txt which is still there for backward compatibility as some of the scripts are relying on it as the source of seed nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BuHeP BuHeP BuHeP left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

building.md build instructions are out of date
3 participants
@Gandalf-the-Grey @Jolly-Pirate @BuHeP