imgproc_cache: Limit cache size to 90% of filesystem size #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm attempting to debug an issue where we get SIGBUS during `_cache_put`. SIGBUS can happen when attempting to fault in a page when there is insufficient space on the backing store to allocate one. This should help prevent that situation, and we should get a `MapFullError` instead. Instead of just warning we now just delete the cache if it's full to resolve any issues like this. It's safe to do so while the database is open, and the database will just be re-created when the next test-run starts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to debug an issue where we get SIGBUS during
_cache_put. SIGBUS can happen when attempting to fault in a page when there is insufficient space on the backing store to allocate one. This should help prevent that situation, and we should get aMapFullErrorinstead.Instead of just warning we now just delete the cache if it's full to resolve any issues like this. It's safe to do so while the database is open, and the database will just be re-created when the next test-run starts.