[WIP] FixedFocusNavigator #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO:
- [ ] Specify the property_name in the constructor, not in navigate_to.
- [ ] Default it to `.text` or `.selection.text`
- [ ] Allow specifying a general "key" function, not just property
names? What to call it that isn't "key"? (Can be confused with
button names).
- [ ] Allow specifying a general comparator function? Is this necessary
for menus with pictures instead of text?
- [ ] Use wait_for_transition.
- [ ] Tests.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
.textor.selection.textnames? What to call it that isn't "key"? (Can be confused with
button names).
for menus with pictures instead of text?