librification: Remove global state from _stbt #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get/set_config
mechanism is a way of storing state in configuration files. This state is global, meaning that you couldn't have different devices under test configured separately in the same process.This commit fixes that issue by pulling a config object into the
DeviceUnderTest
class. This is a fairly blunt approach but it works for now. Perhaps in the future the specific keys that theDeviceUnderTest
class needs can be directly injected.I'm not 100% sold on this change yet, but I've created this PR as a place to discuss. This is obviously related to #297, although I'm not planning on ticking all the rest of the items from there off immediately.