feat: Start bridge from asset drawer #19860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
force-pushed
the
fix/asset-bridge
branch
from
2bfbd34
to
8a001a4
Compare
OmarBasem
requested review from
clauxx,
mmilad75,
ulisesmac,
mohsen-ghafouri and
ajayesivan
Jenkins BuildsClick to see older builds (24)
|
vkjr
approved these changes
May 1, 2024
| @@ -241,12 +241,16 @@ | |||
| (rf/reg-event-fx :wallet/get-keypairs get-keypairs) | |||
|
|
|||
| (rf/reg-event-fx :wallet/bridge-select-token | |||
| (fn [{:keys [db]} [{:keys [token stack-id]}]] | |||
| (fn [{:keys [db]} [{:keys [token stack-id from-drawer?]}]] | |||
There was a problem hiding this comment.
I'd suggest to rename from-drawer? -> open-modal? because the event don't need to know any information about surrounding context, wdyt?
mohsen-ghafouri
approved these changes
May 1, 2024
mmilad75
reviewed
May 1, 2024
| :on-press #(js/alert "to be implemented")}) | ||
| :on-press (fn [] | ||
| (rf/dispatch [:hide-bottom-sheet]) | ||
| (rf/dispatch [:wallet/bridge-select-token |
There was a problem hiding this comment.
You should be using the bridging wizard instead and should add a new flow for bridge
There was a problem hiding this comment.
I agree @mmilad75, this is a ideal use case for wizard navigation.
There was a problem hiding this comment.
@mmilad75 fixed it. Could you please have a look at the code changes.
And here is a video:
Screen_Recording_20240502_094056_Status.mp4
OmarBasem
force-pushed
the
fix/asset-bridge
branch
from
8a001a4
to
b10c251
Compare
mmilad75
approved these changes
May 2, 2024
90% of end-end tests have passedFailed tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (47)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
|
|
Hi @OmarBasem thanks for the PR! ISSUE 1: Error when starting the bridge flowSteps:
video_2024-05-03_11-39-11.mp4Please do not forget to smoke-test PR changes on real devices when / if possible 🙏 Also, a wrong issue seems to be linked to this PR in the description (it's already closed #19807). Please edit the description accordingly. |
OmarBasem
force-pushed
the
fix/asset-bridge
branch
2 times, most recently
from
43aa085
to
0a9260d
Compare
J-Son89
reviewed
May 6, 2024
J-Son89
reviewed
May 6, 2024
J-Son89
reviewed
May 6, 2024
J-Son89
reviewed
May 6, 2024
|
@OmarBasem please lmk when the conflict and all the review comments are resolved, I'll recheck the PR, thanks! |
OmarBasem
force-pushed
the
fix/asset-bridge
branch
2 times, most recently
from
f5cea34
to
863449a
Compare
10% of end-end tests have passedFailed tests (46)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
|
80% of end-end tests have passedFailed tests (8)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Expected to fail tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (37)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
|
|
hi @OmarBasem, thanks for the PR, e2e failures are not related |
|
Thanks @OmarBasem and @yevh-berdnyk! |
OmarBasem
force-pushed
the
fix/asset-bridge
branch
from
863449a
to
3c54307
Compare
OmarBasem
force-pushed
the
fix/asset-bridge
branch
from
3c54307
to
e31ab0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #19806
This PR implements starting the bridge flow from the assets drawer.
Note: the bridge flow has some bugs and is still under development
Demo:
Screen_Recording_20240501_152120_Status.mp4