Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More reagent atom regression #19812 #19828

Merged
merged 1 commit into from May 1, 2024
Merged

More reagent atom regression #19812 #19828

merged 1 commit into from May 1, 2024

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Apr 29, 2024 •
edited

fixes #19812

  • ISSUE 1: Scroll to the bottom button (tested manually)
  • ISSUE 2: Link preview inside the composer (tested manually)
  • ISSUE 3: Loading skeleton on iOS (tested manually)
  • ISSUE 4: Wrong letter and background color of the channel avatar (not related to the theme, its a customization color)

@flexsurfer flexsurfer self-assigned this Apr 29, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 29, 2024
ibrkhalil
ibrkhalil approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ibrkhalil ibrkhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@status-im-auto
Copy link
Member

status-im-auto commented Apr 29, 2024 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 324d009 #1 2024-04-29 11:43:48 ~4 min tests 📄log
✔️ 324d009 #1 2024-04-29 11:47:56 ~8 min ios 📱ipa 📲
✔️ 324d009 #1 2024-04-29 11:49:46 ~10 min android-e2e 🤖apk 📲
✔️ 324d009 #1 2024-04-29 11:49:58 ~10 min android 🤖apk 📲

@flexsurfer flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Apr 29, 2024
@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 52
Failed tests: 0
Expected to fail tests: 2
Passed tests: 50

IDs of expected to fail tests: 703495,703503

Expected to fail tests (2)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

# STEP: Change device time so chat will be unmuted by timer
Device 2: Long press on `ChatElement` 

critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

[[Chat is not unmuted after expected time: https://github.com//issues/19627]]

Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503 

Test is not run, e2e blocker

[[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (50)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions

2. test_community_one_image_send_reply, id: 702859
Device sessions

3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions

4. test_community_mark_all_messages_as_read, id: 703086
Device sessions

5. test_community_contact_block_unblock_offline, id: 702894
Device sessions

6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions

7. test_community_message_delete, id: 702839
Device sessions

8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions

9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions

10. test_community_message_edit, id: 702843
Device sessions

11. test_community_unread_messages_badge, id: 702841
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions

3. test_1_1_chat_push_emoji, id: 702813
Device sessions

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

5. test_1_1_chat_edit_message, id: 702855
Device sessions

6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions

7. test_1_1_chat_pin_messages, id: 702731
Device sessions

8. test_1_1_chat_message_reaction, id: 702730
Device sessions

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions

2. test_links_deep_links, id: 702775
Device sessions

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions

2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions

2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions

3. test_1_1_chat_mute_chat, id: 703496
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

3. test_community_undo_delete_message, id: 702869
Device sessions

4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions

5. test_community_mute_community_and_channel, id: 703382
Device sessions

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions

2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions

3. test_activity_center_contact_request_decline, id: 702850
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions

2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions

3. test_group_chat_reactions, id: 703202
Device sessions

4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions

5. test_group_chat_offline_pn, id: 702808
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

2. test_wallet_add_remove_watch_only_account, id: 727232
Device sessions

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions

2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions

3. test_community_mentions_push_notification, id: 702786
Device sessions

4. test_community_leave, id: 702845
Device sessions

5. test_community_join_when_node_owner_offline, id: 703629
Device sessions

@flexsurfer flexsurfer merged commit 6037fe8 into develop May 1, 2024
6 of 7 checks passed
Pipeline for QA automation moved this from E2E Tests to DONE May 1, 2024
@flexsurfer flexsurfer deleted the bug/More_reagent_atom_regression_#19812 branch May 1, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parveshdhull Parveshdhull Parveshdhull approved these changes

@ibrkhalil ibrkhalil ibrkhalil approved these changes

Assignees

@flexsurfer flexsurfer

Labels
skip-manual-qa
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More reagent atom regression
4 participants
@flexsurfer @status-im-auto @Parveshdhull @ibrkhalil