fix: archive decryption fail #5076
Open
+288
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (36)
|
jrainville
approved these changes
Apr 18, 2024
osmaczko
approved these changes
Apr 19, 2024
igor-sirotin
force-pushed
the
fix/archive-decryption-fail
branch
2 times, most recently
from
b18626c
to
e45af80
Compare
😬 communities_messenger_token_permissions_test.go:1837:
Error Trace: /Users/igorsirotin/Repositories/Status/status-desktop/vendor/status-go/protocol/communities_messenger_token_permissions_test.go:1837
Error: "[]" should have 1 item(s), but has 0
Test: TestMessengerCommunitiesTokenPermissionsSuite/TestImportDecryptedArchiveMessages |
|
So I have 2 main reasons for the test flakiness:
|
igor-sirotin
force-pushed
the
fix/archive-decryption-fail
branch
2 times, most recently
from
9f18f00
to
2ab63b9
Compare
igor-sirotin
force-pushed
the
fix/archive-decryption-fail
branch
from
390506f
to
138505d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes status-im/status-desktop#13105
➡️ Pro Tip: review by commits.
The problem was that we kept trying to decrypt the archives in a loop, though we obviously didn't have hash ratchet keys for it (for the archives themselves, not the messages inside). The fix is to postpone the next attempt import attempt. If we don't have the key for this archive, we don't have all the further ones as well.
I also wrote a test that ensures that the the archive protocol works properly for the community channel-level encryption.