Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic for checking if the route can be established updated #5072

Merged
merged 1 commit into from May 15, 2024

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Apr 18, 2024

toToken is used only when the user wants to swap, since Can function from the Bridge interface receives toToken which is nil for all but for the swap, we need to consider it and return appropriately from the function.

@status-im-auto
Copy link
Member

status-im-auto commented Apr 18, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ ad0f63c #1 2024-04-18 10:26:26 ~1 min tests 📄log
✔️ ad0f63c #1 2024-04-18 10:29:47 ~4 min linux 📦zip
✔️ ad0f63c #1 2024-04-18 10:30:18 ~5 min ios 📦zip
✔️ ad0f63c #1 2024-04-18 10:30:57 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 6ac2d64 #2 2024-04-19 07:54:42 ~1 min tests 📄log
✔️ 6ac2d64 #2 2024-04-19 07:57:33 ~4 min linux 📦zip
✔️ 6ac2d64 #2 2024-04-19 07:58:43 ~5 min ios 📦zip
✔️ 6ac2d64 #2 2024-04-19 07:59:11 ~5 min android 📦aar
✔️ c53b3a5 #3 2024-05-07 07:21:21 ~3 min linux 📦zip
✔️ c53b3a5 #3 2024-05-07 07:22:19 ~4 min ios 📦zip
✔️ c53b3a5 #3 2024-05-07 07:22:33 ~5 min android 📦aar
✔️ c53b3a5 #3 2024-05-07 08:00:31 ~43 min tests 📄log

@IvanBelyakoff
Copy link
Contributor

@saledjenic, when can this happen that toToken is nil?

@saledjenic
Copy link
Contributor Author

@saledjenic, when can this happen that toToken is nil?

@IvanBelyakoff toToken is used only for the Swap, thus for all other types will be nil.

@J-Son89
Copy link
Member

J-Son89 commented Apr 29, 2024

@saledjenic - any chance you can include a description to this pr of what these changes are doing and why they were needed? 🙏
Also is there an associated issue for this?

@cammellos
Copy link
Member

it'd be good also to add some level of tests, so that the behavior is clearer and we know it matches the dev's intention

@saledjenic
Copy link
Contributor Author

@saledjenic - any chance you can include a description to this pr of what these changes are doing and why they were needed? 🙏
Also is there an associated issue for this?

@J-Son89 description updated. No special issue just for this, cause this was missed when swap was added to the router. We don't have any UI for it yet, just a backend logic, otherwise it would be noticed and logged as an issue. I noticed this and wanted to handle it.

it'd be good also to add some level of tests, so that the behavior is clearer and we know it matches the dev's intention

@cammellos I agree, maybe we can add them after we improve the router logic, cause I see we have many issues with the router.

@saledjenic saledjenic force-pushed the fix/router-can-logic-update branch from 6ac2d64 to c53b3a5 Compare May 7, 2024 07:17
@J-Son89
Copy link
Member

J-Son89 commented May 7, 2024

thanks @saledjenic!

@saledjenic saledjenic merged commit c9ee0e0 into develop May 15, 2024
7 checks passed
@saledjenic saledjenic deleted the fix/router-can-logic-update branch May 15, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants