New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logic for checking if the route can be established updated #5072
Conversation
Jenkins BuildsClick to see older builds (4)
|
ad0f63c
to
6ac2d64
Compare
@saledjenic, when can this happen that toToken is nil? |
@IvanBelyakoff |
@saledjenic - any chance you can include a description to this pr of what these changes are doing and why they were needed? 🙏 |
it'd be good also to add some level of tests, so that the behavior is clearer and we know it matches the dev's intention |
@J-Son89 description updated. No special issue just for this, cause this was missed when swap was added to the router. We don't have any UI for it yet, just a backend logic, otherwise it would be noticed and logged as an issue. I noticed this and wanted to handle it.
@cammellos I agree, maybe we can add them after we improve the router logic, cause I see we have many issues with the router. |
6ac2d64
to
c53b3a5
Compare
thanks @saledjenic! |
toToken
is used only when the user wants to swap, sinceCan
function from theBridge
interface receivestoToken
which isnil
for all but for the swap, we need to consider it and return appropriately from the function.