chore: Fix Windows build #5067
Merged
chore: Fix Windows build #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
Cuteivist
force-pushed
the
chore/fix-windows-build
branch
from
961729d
to
81d969d
Compare
Cuteivist
force-pushed
the
chore/fix-windows-build
branch
from
81d969d
to
d91bd8a
Compare
jakubgs
approved these changes
May 6, 2024
There was a problem hiding this comment.
Windows doesn't have NIX platform.
You can use Nix via WSL2: https://github.com/nix-community/NixOS-WSL
Also, why would you develop on Windows? Are you a masochist?
Makefile
Outdated
| @@ -105,7 +105,9 @@ endef | |||
|
|
|||
| # TODO: Define more specific shells. | |||
| TARGET := default | |||
| SHELL := ./nix/scripts/shell.sh | |||
| ifneq ($(detected_OS),Windows) | |||
| SHELL := ./nix/scripts/shell.sh | |||
There was a problem hiding this comment.
The indent is unnecessary. This is not a target.
Suggested change
| SHELL := ./nix/scripts/shell.sh | |
| SHELL := ./nix/scripts/shell.sh |
Cuteivist
force-pushed
the
chore/fix-windows-build
branch
from
d91bd8a
to
d014627
Compare
|
@jakubgs Thank you for review.
Users will use Windows too, even someone will try to build it on Windows. It's good to have at least 1 dev on Windows to keep build process in the shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't have NIX platform.
Building status-go on Windows caused these errors:
$ make status-go
make status-go
Tip of the day: this will probably build faster if you use "make.exe -j32 ...".
Building: status-go
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 10: cd: D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: Not a directory
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 11: /scripts/colors.sh: No such file or directory
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 12: /nix/scripts/source.sh: No such file or directory
Configuring Nix shell for target 'default'...
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 65: /nix/scripts/gcroots.sh: No such file or directory
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 73: exec: nix-shell: not found
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 10: cd: D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: Not a directory
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 11: /scripts/colors.sh: No such file or directory
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 12: /nix/scripts/source.sh: No such file or directory
Configuring Nix shell for target 'default'...
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 65: /nix/scripts/gcroots.sh: No such file or directory
D:\git\status\status-desktop-tmp\vendor\status-go\nix\scripts\shell.sh: line 73: exec: nix-shell: not found
make[1]: *** [Makefile:225: statusgo-shared-library] Error 127
make: *** [Makefile:433: vendor/status-go/build/bin/libstatus.dll] Error 2