fix: Add twitterHandle for a collectible #5007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (133)
|
Khushboo-dev-cpp
force-pushed
the
AddTwitterHandleForACollectible
branch
18 times, most recently
from
9d04dfb
to
fd25beb
Compare
4 tasks
Khushboo-dev-cpp
force-pushed
the
AddTwitterHandleForACollectible
branch
4 times, most recently
from
92263e6
to
a4080c1
Compare
stefandunca
approved these changes
May 1, 2024
walletdatabase/migrations/sql/1712763613_add_collection_socials.up.sql
Outdated
Show resolved
Hide resolved
dlipicar
reviewed
May 1, 2024
walletdatabase/migrations/sql/1712763613_add_collection_socials.up.sql
Outdated
Show resolved
Hide resolved
walletdatabase/migrations/sql/1712763613_add_collection_socials.up.sql
Outdated
Show resolved
Hide resolved
dlipicar
reviewed
May 1, 2024
dlipicar
requested changes
May 1, 2024
Khushboo-dev-cpp
force-pushed
the
AddTwitterHandleForACollectible
branch
9 times, most recently
from
d39459e
to
e5d4a07
Compare
dlipicar
reviewed
May 8, 2024
Khushboo-dev-cpp
force-pushed
the
AddTwitterHandleForACollectible
branch
from
e5d4a07
to
2bee5b3
Compare
dlipicar
reviewed
May 13, 2024
Khushboo-dev-cpp
force-pushed
the
AddTwitterHandleForACollectible
branch
from
2bee5b3
to
cc6867b
Compare
dlipicar
reviewed
May 13, 2024
…witter handle from alchemy
Khushboo-dev-cpp
force-pushed
the
AddTwitterHandleForACollectible
branch
from
cc6867b
to
c887192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary which serves as a squashed-commit message.
Adds new table to hold collection socials such website and twitter handle. We can only rely on Alchemy to provide this data as of now due to missing api in rarible and opensea requests limitation.
In case Alchemy is the default provider we add values in the collection_socials_cache db. And in case other providers are being used the socials will be fetched from alchmey async and a signal with filled data will be sent to the client.
A description to understand introduced changes without reading the code.
Important changes:
Closes #