Extend peersyncing to sync 1-to-1 messages #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (138)
|
alwx
force-pushed
the
peer-syncing-one-to-one
branch
from
1ec5cd8
to
ff27bff
Compare
|
Any chance to get a review for this one? :) |
cammellos
approved these changes
Apr 4, 2024
vitvly
requested changes
Apr 8, 2024
protocol/messenger_peersyncing.go
Outdated
| @@ -133,22 +151,22 @@ func (m *Messenger) sendDatasyncOffers() error { | |||
| continue | |||
| } | |||
|
|
|||
| availableMessages, err := m.peersyncing.AvailableMessagesByGroupIDs(chatIDs, maxAdvertiseMessages) | |||
| availableMessages, err := m.peersyncing.AvailableMessagesByChatIDs(chatIDs, maxAdvertiseMessages) | |||
There was a problem hiding this comment.
We seem to be constructing a chatID->msgID map in all cases when we invoke m.peersyncing.AvailableMessagesByChatIDs - maybe makes sense to make the latter fn return that map instead. (unless i missed some other uses)
alwx
force-pushed
the
peer-syncing-one-to-one
branch
from
cc62324
to
0ba86f7
Compare
vitvly
approved these changes
Apr 16, 2024
alwx
force-pushed
the
peer-syncing-one-to-one
branch
8 times, most recently
from
f86f812
to
d9a6fbf
Compare
alwx
force-pushed
the
peer-syncing-one-to-one
branch
from
09cd871
to
a50fb55
Compare
alwx
force-pushed
the
peer-syncing-one-to-one
branch
from
a50fb55
to
f8abe7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-mobile#18957
Updates peer syncing so that it works not only for communities but also for one-to-one chats.