Hide Create Community button #14545
Hide Create Community button #14545
Conversation
| Global.createCommunityPopupRequested(true /*isDiscordImport*/) | ||
| Loader { | ||
| Layout.preferredHeight: active ? 38 : 0 | ||
| active: communitiesStore.createCommunityEnabled || communitiesStore.testEnvironment |
There was a problem hiding this comment.
Showing it on testEnvironment: true is important, otherwise a lot of tests would fail.
There was a problem hiding this comment.
Maybe write this in the code as comment as well?
Jenkins Builds
|
jrainville
force-pushed
the
chore/hide-create-comm-button-for-real
branch
from
cc12b63
to
21be41a
Compare
jrainville
changed the title
| Global.createCommunityPopupRequested(true /*isDiscordImport*/) | ||
| Loader { | ||
| Layout.preferredHeight: active ? 38 : 0 | ||
| active: communitiesStore.createCommunityEnabled || communitiesStore.testEnvironment |
There was a problem hiding this comment.
Maybe write this in the code as comment as well?
| objectName: "createCommunityButton" | ||
| Layout.preferredHeight: 38 | ||
| verticalPadding: 0 | ||
| text: qsTr("Import existing community from Discord") |
There was a problem hiding this comment.
Should we maybe the import from discord button commented here? so that it's easier to bring it back later.
There was a problem hiding this comment.
That's actually from the revert. This button doesn't exist on master.
There was a problem hiding this comment.
oh ok. I'd rather leave it in master ,but it's too late 😄
There was a problem hiding this comment.
I mean, this button never existed. In the original commit I did to hide the Create community, I thought we still wanted the Import Community button, but turns out we didn't so I reverted.
You can check the different commits to see
Fixes #14530
(includes a revert of the previous hide that wasn't exactly what we wanted)
community-creation.webm
Known issue: if you disable the setting, the Loader doesn't lose its width. It,s not a huge deal, as it's not a common use case, but if the UI team has an easy fix, might as well.